From 452523feda732f0c766eeabf813a5063f9ab0d3a Mon Sep 17 00:00:00 2001 From: Alejandro Rizzo Date: Fri, 26 Jun 2026 13:10:15 +0100 Subject: [PATCH 1/2] fix(ci): skip changeset-check on the version-packages PR MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The changesets bot's "chore: version packages" PR (branch changeset-release/main) consumes changesets — it deletes the .md files and bumps versions, adding none. The changeset-check job counts only added/modified .changeset/*.md files (--diff-filter=AM), so it always reported 0 and failed on that PR (e.g. #22), even though the PR is correct by construction. Guard the job so it runs for normal PRs but skips the bot's version PR: `github.head_ref != 'changeset-release/main'`. Co-Authored-By: Claude Opus 4.8 (1M context) --- .changeset/skip-changeset-check-on-version-pr.md | 7 +++++++ .github/workflows/ci.yml | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 .changeset/skip-changeset-check-on-version-pr.md diff --git a/.changeset/skip-changeset-check-on-version-pr.md b/.changeset/skip-changeset-check-on-version-pr.md new file mode 100644 index 0000000..69475f4 --- /dev/null +++ b/.changeset/skip-changeset-check-on-version-pr.md @@ -0,0 +1,7 @@ +--- +--- + +Internal CI change (no version bump): skip the `changeset-check` job on the +changesets bot's "version packages" PR (`changeset-release/main`). That PR +consumes (deletes) changesets rather than adding them, so the check counted 0 +added/modified changeset files and always failed. diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7c7f145..b39f818 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,7 +39,9 @@ jobs: run: npm test changeset-check: - if: github.event_name == 'pull_request' + # Skip the changesets bot's "version packages" PR: it consumes (deletes) + # changesets rather than adding them, so it would always fail this check. + if: github.event_name == 'pull_request' && github.head_ref != 'changeset-release/main' runs-on: ubuntu-latest steps: From a64cbf6dafc2d983f6d72f0757f4c2b1afb4b145 Mon Sep 17 00:00:00 2001 From: Alejandro Rizzo Date: Fri, 26 Jun 2026 13:15:03 +0100 Subject: [PATCH 2/2] chore(ci): match changeset-release/ prefix in changeset-check skip Per review (Codacy): the changesets bot branches as changeset-release/, so use !startsWith(github.head_ref, 'changeset-release/') instead of an exact match on 'changeset-release/main'. Same behavior for this repo today, but robust to other base branches. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b39f818..52a9b03 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,7 +41,8 @@ jobs: changeset-check: # Skip the changesets bot's "version packages" PR: it consumes (deletes) # changesets rather than adding them, so it would always fail this check. - if: github.event_name == 'pull_request' && github.head_ref != 'changeset-release/main' + # The bot branches as changeset-release/, so match the prefix. + if: github.event_name == 'pull_request' && !startsWith(github.head_ref, 'changeset-release/') runs-on: ubuntu-latest steps: