Broken build with system liburiparser

[remicollet]

Description

Build is broken using --with-external-uriparser

/usr/bin/ld: ext/uri/uri_parser_rfc3986.o: in function `php_uri_parser_rfc3986_validate_host':
/builddir/build/BUILD/php86-php-8.6.0_alpha1-build/php-8.6.0alpha1/ext/uri/uri_parser_rfc3986.c:746:(.text+0x148d): undefined reference to `uriIsWellFormedHostIp6A'
/usr/bin/ld: /builddir/build/BUILD/php86-php-8.6.0_alpha1-build/php-8.6.0alpha1/ext/uri/uri_parser_rfc3986.c:740:(.text+0x14dc): undefined reference to `uriIsWellFormedHostIpFutureA'
/usr/bin/ld: ext/uri/uri_parser_rfc3986.o: in function `php_uri_parser_rfc3986_validate_host':
/builddir/build/BUILD/php86-php-8.6.0_alpha1-build/php-8.6.0alpha1/ext/uri/uri_parser_rfc3986.c:746:(.text+0x148d): undefined reference to `uriIsWellFormedHostIp6A'
/usr/bin/ld: /builddir/build/BUILD/php86-php-8.6.0_alpha1-build/php-8.6.0alpha1/ext/uri/uri_parser_rfc3986.c:740:(.text+0x14dc): undefined reference to `uriIsWellFormedHostIpFutureA'
/usr/bin/ld: ext/uri/uri_parser_rfc3986.o: in function `php_uri_parser_rfc3986_validate_host':
/builddir/build/BUILD/php86-php-8.6.0_alpha1-build/php-8.6.0alpha1/ext/uri/uri_parser_rfc3986.c:746:(.text+0x148d): undefined reference to `uriIsWellFormedHostIp6A'
/usr/bin/ld: /builddir/build/BUILD/php86-php-8.6.0_alpha1-build/php-8.6.0alpha1/ext/uri/uri_parser_rfc3986.c:740:(.text+0x14dc): undefined reference to `uriIsWellFormedHostIpFutureA'

PHP Version

8.6.0alpha1

Operating System

N/A

[remicollet]

This function was introduced in 0.9.9 but is not part of the public API

uriIsWellFormedHostIp4A is public

URI_PUBLIC UriBool URI_FUNC(IsWellFormedHostIp4)(const URI_CHAR * first,
                                                 const URI_CHAR * afterLast);

uriIsWellFormedHostIp6A is NOT public

int URI_FUNC(IsWellFormedHostIp6)(const URI_CHAR * first, const URI_CHAR * afterLast);

This probably means we need to submit a change upstream... wait for a new release... and bump the minimal required version :(

[remicollet]

Introduced in 3f285f4 by @kocsismate

[kocsismate]

@remicollet Uh, sorry for that. I can submit the upstream fix later today.

[hartwork]

FYI there is uriparser/uriparser#328 upstream now.

CC @kocsismate @DanielEScherzer

[remicollet]

Thanks for upstream patch, but sadly, still not enough

/usr/bin/ld: ext/uri/uri_parser_rfc3986.o: in function `php_uri_parser_rfc3986_validate_host':
/builddir/build/BUILD/php86-php-8.6.0_alpha1-build/php-8.6.0alpha1/ext/uri/uri_parser_rfc3986.c:740:(.text+0x14dc): undefined reference to `uriIsWellFormedHostIpFutureA'
/usr/bin/ld: ext/uri/uri_parser_rfc3986.o: in function `php_uri_parser_rfc3986_validate_host':
/builddir/build/BUILD/php86-php-8.6.0_alpha1-build/php-8.6.0alpha1/ext/uri/uri_parser_rfc3986.c:740:(.text+0x14dc): undefined reference to `uriIsWellFormedHostIpFutureA'
/usr/bin/ld: ext/uri/uri_parser_rfc3986.o: in function `php_uri_parser_rfc3986_validate_host':
/builddir/build/BUILD/php86-php-8.6.0_alpha1-build/php-8.6.0alpha1/ext/uri/uri_parser_rfc3986.c:740:(.text+0x14dc): undefined reference to `uriIsWellFormedHostIpFutureA'