chore: run unit tests on CI#52
Draft
janicduplessis wants to merge 2 commits into
Draft
Conversation
… collision The app project generated by expo prebuild was named Ease, the same as the development pod. CocoaPods recreates a user scheme for the pod on every pod install, and xcodebuild resolved -scheme Ease to the pod's scheme, so expo run:ios built only the static library and then failed to find the app binary. Naming the app EaseExample keeps the two schemes distinct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI had lint and build jobs but never ran the Jest suite, so the prop-resolution tests in
src/__tests__/(~1000 lines) gated nothing — a regression in the JS layer would ship silently. This adds atestjob mirroring the existinglintjob.Test Plan
yarn testpasses locally (3 suites, 82 tests). This PR's own CI run demonstrates the new job working.