fix: use canonical www.codebuff.com URL for fallbacks#840
Open
OmarAlaaeldein wants to merge 1 commit into
Open
fix: use canonical www.codebuff.com URL for fallbacks#840OmarAlaaeldein wants to merge 1 commit into
OmarAlaaeldein wants to merge 1 commit into
Conversation
When fallback URLs point to codebuff.com, the server redirects to www.codebuff.com with a 301 redirect. During this redirect, Node's fetch client strips the Authorization header (for security reasons), causing validation/session requests to fail with a 401 Unauthorized. This changes hardcoded fallbacks to the canonical www.codebuff.com to avoid redirect-induced credential stripping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a silent authorization header-stripping issue during local development/testing.
https://codebuff.comto the canonicalhttps://www.codebuff.com.codebuff.comtowww.codebuff.comwhich causes Node'sfetchclient to strip theAuthorizationheader for security reasons, resulting in a silent401 Unauthorizederror.