fix: defer VS Code auto theme to platform#841
Open
vamshikrishnaramasamy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #834.
When VS Code has
window.autoDetectColorSchemeenabled, the CLI should defer to the platform theme detector instead of inferring the theme fromworkbench.preferredDarkColorThemefirst. Otherwise auto-detect can stick to the preferred dark theme even when macOS is in light mode.This keeps explicit
workbench.colorThemehandling unchanged and adds focused coverage for the VS Code settings parser.Tests:
bun test src/__tests__/utils/theme-system.test.tsNote:
bun run typecheckcurrently fails on unrelated existingreact-dom/serverdeclaration errors in CLI component tests.