Add functional tests for the new Symfony module assertions#63
Open
TavoNiievez wants to merge 3 commits into
Open
Add functional tests for the new Symfony module assertions#63TavoNiievez wants to merge 3 commits into
TavoNiievez wants to merge 3 commits into
Conversation
A flash-and-redirect controller (assertSessionHasFlashMessage), a Greeting service swapped via mockService, a query-heavy page for the Doctrine query-count assertions, and an in-memory 'async' transport with SendWelcomeMessage routed to it for the Messenger transport assertions.
Cover assertSessionHasFlashMessage, mockService, seeNumQueriesIsLessThan, dontSeeDuplicateQueries, and the Messenger in-memory transport assertions (grab/seeContains/seeQueueCount/consume).
runCommand() and assertCommandIsSuccessful/Failed/IsInvalid/ResultEquals are Symfony 8.1+ only, so they are covered on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional coverage for the new assertions added in codeception/module-symfony (
assertSessionHasFlashMessage, the consoleExecutionResultassertions,mockService/unmockService,seeNumQueriesIsLessThan/dontSeeDuplicateQueries, and the Messenger in-memory transport assertions).Adds the matching app fixtures:
/flash) forassertSessionHasFlashMessage;ResultCommandexercising success / failure / invalid / stderr forrunCommand()+assertCommand*(Symfony 8.1+ only, hence on this branch);Greetingservice +/greetingpage swapped viamockService;/run-queriespage for the Doctrine query-count assertions;asynctransport withSendWelcomeMessagerouted to it for the Messenger transport assertions.