Skip to content

Reorganize the documentation#335

Merged
xlamorlette-datadog merged 6 commits into
mainfrom
xlamorlette/reorganize-documentation
Jul 3, 2026
Merged

Reorganize the documentation#335
xlamorlette-datadog merged 6 commits into
mainfrom
xlamorlette/reorganize-documentation

Conversation

@xlamorlette-datadog

@xlamorlette-datadog xlamorlette-datadog commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Description

This reorganizes the documentation as follows:

  • Rename the doc folder to docs.
  • Rename maintainers documentation to design.
  • Create a basic development documentation from the 'Test' section of the main readme and the 'Code Style' section of contributing.
  • Move the 'Logical Component Relationships' section from doc/readme to design.
  • Reference security in the main readme.

Motivation

Get a better organization of the documentation, before updating to bring it up to date.

Additional Notes

Jira ticket: IDMPL-549 C++ Tracer: update and improve architecture documentation

@pr-commenter

pr-commenter Bot commented Jul 3, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-03 13:17:56

Comparing candidate commit fff3c49 in PR branch xlamorlette/reorganize-documentation with baseline commit 64f90a7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 3, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 91.66% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fff3c49 | Docs | Datadog PR Page | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 94c3760cdd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/README.md Outdated
Comment thread docs/development.md Outdated
Comment thread SECURITY.md Outdated
share the details in a public forum (such as in a discussion, issue, or pull request) but instead
reach out to us with the details. This gives us an opportunity to release a fix for others to
benefit from by the time details are made public.
This document outlines the security policy for the Datadog C++ Tracing Library and what to do if you

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, we should call dd-trace-* a client library and not a tracing library acutally.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call it 'APM client library'?

@xlamorlette-datadog xlamorlette-datadog Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose 'Datadog C++ Tracer' = 'Datadog APM C++ client library'.

In the main Readme, to be reflected in all documentation files:

# Datadog C++ Tracer

This dd-trace-cpp repository contains the Datadog C++ Tracer, which is the [Datadog Application
Performance Monitoring (APM)](https://docs.datadoghq.com/tracing) C++ client library.

Comment thread docs/development.md Outdated
Comment on lines +1 to +24
# Development Processes

## Test

Pass `-DDD_TRACE_BUILD_TESTING=1` to `cmake` to include the unit tests in the build.

The resulting unit test executable is `test/tests` within the build directory.

```shell
cmake -B build -DDD_TRACE_BUILD_TESTING=1 .
cmake --build build -j
./build/test/tests
```

Alternatively, [bin/test](../bin/test) is provided for convenience.

## Code Style

C++ code is formatted using `clang-format-14`. Before submitting code changes, run the following
command:

```shell
bin/format
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think this kind of information should be in the contributing.md because this is common to people.
Putting this information here is not too much of a deal but it's not super straightforward

@xlamorlette-datadog xlamorlette-datadog Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to have all the documentation for developers (design and development process) side by side in the same folder.

The Contributing document at the root of the repository becomes kind of a link to this documentation:
“Please refer to the documentation to learn about the architecture of the Datadog of C++ Tracing
Library and the development processes, notably testing and code formatting, which are mandatory before submitting code changes.”

I think we could even remove this Contributing document at the root and only keep a tiny Contributing section in the Readme at the root, but I suppose it's better to keep both: a tiny document at the root and a tiny section in the Readme, both redirecting to the documentation in the docs folder (same for Security).

What do you think?

@dubloom dubloom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'm not a fan of being redirect across documents in a repo but you're the maintainer and I don't have strong opinions

@xlamorlette-datadog xlamorlette-datadog merged commit 2536f5e into main Jul 3, 2026
38 checks passed
@xlamorlette-datadog xlamorlette-datadog deleted the xlamorlette/reorganize-documentation branch July 3, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants