Checkout PR ref when creating mirror images#169
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbaeb1e4a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| path: dd-trace-java-docker-build | ||
| ref: refs/pull/${{ github.event.inputs.pr_number }}/merge |
There was a problem hiding this comment.
Just thinking if we really need this?
I think that if we need to update CI_VARAINTS we can simply merge that to master in order not to produce one-time-use images. WDYT?
Or probably we better start working on moving this image into dd-trace-java directly.
I recall @bric3 mentioned that it is very possible.
There was a problem hiding this comment.
I think that if we need to update CI_VARAINTS we can simply merge that to master in order not to produce one-time-use images. WDYT?
We'd only produce one extra one-time-use image (for the new variant) in the same group that gets deleted with the other test CI images 🤔 - which reminds me to apply this to the delete workflow too. The changes don't add any permanent images or additional workflows.
The CI_VARIANTS variable determines how the images are tagged, so if we added the variant to master first, we'd be adding a new tagged image to the master workflow without it being tested.
I think it makes more sense to be updating the CI_VARIANTS tagging in the same PR that the image itself is tested and added.
probably we better start working on moving this image into dd-trace-java directly.
This comment explains why we should stick to two separate workflows.
|
Confirmed this works with the changes in #168: https://github.com/DataDog/images/pull/10529/changes! |
2 participants
Checkout the repo at the inputted PR ref when creating mirror images. This ensures that new CI_VARIANTS included in the PR, e.g. for adding new JDK versions, are mirrored instead of using the
masterbranch's CI_VARIANTS.