refactor(render-pdf): remove the legacy ECS PDF render tree#320
Merged
Conversation
Delete the dead Entity-Component-System PDF renderer: the package engine.render.pdf.ecs and its handlers/helpers sub-packages (PdfRenderingSystemECS, the ecs PdfRenderSession/PdfCanvas/PdfStream/ PdfImageCache/PdfFileManagerSystem/PdfGuidesRenderer, the 13 render handlers, and the TableCellBox/PdfBookmarkBuilder helpers). Canonical PDF output goes through document.backend.fixed.pdf (PdfFixedLayoutBackend + PdfFragmentRenderHandler); no public API, ServiceLoader registration, or reflection reaches the ecs path, so it is production-dead. Repoint the contributor docs (implementation-guide, package-map, overview, CONTRIBUTING) from the deleted ecs handler/helper packages to the canonical PdfFragmentRenderHandler surface, drop the CI guard-list and doc links to the already-removed PdfRenderingSystemECSDispatchTest, and remove the now-moot japicmp excludes for the deleted classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
com.demcha.compose.engine.render.pdf.ecstree is the old Entity-Component-System PDF renderer. Canonical PDF output has long gone throughcom.demcha.compose.document.backend.fixed.pdf(PdfFixedLayoutBackenddispatching toPdfFragmentRenderHandlerimplementations). The ecs path is reached by no public API, noServiceLoaderregistration, and no reflection — it is production-dead (its tests were already removed).What
engine.render.pdf.ecsand its.handlers/.helperssub-packages — 25 files:PdfRenderingSystemECS, the ecsPdfRenderSession/PdfCanvas/PdfStream/PdfImageCache/PdfFileManagerSystem/PdfGuidesRenderer, the 13Pdf*RenderHandlerclasses, and theTableCellBox/PdfBookmarkBuilderhelpers.implementation-guide.md,package-map.md,overview.md,CONTRIBUTING.md) from the deleted ecs handler/helper packages to the canonicalPdfFragmentRenderHandlersurface underdocument.backend.fixed.pdf.handlers.ci.ymlguard-list entry and the doc links toPdfRenderingSystemECSDispatchTest(removed earlier), and remove the now-moot japicmp excludes for the deleted classes.The canonical render path, the surviving
engine.render.pdfhelpers (header/footer + watermark), and the backend-neutralengine.rendercontracts are untouched.Tests
Full aggregator verify (core + render-pdf + render-docx + render-pptx + templates + testing + qa, incl. the javadoc + documentation-snippet gates):
BUILD SUCCESS, 0 failures, with identical test counts (render-pdf 108, qa 630, …) — confirming nothing referenced the removed tree.examples/benchmarksverified to carry no compile dependency on it.