Exit promptly after parent death#781
Open
SS-42 wants to merge 1 commit into
Open
Conversation
Signed-off-by: SS-42 <noreply@incogni.to>
SS-42
force-pushed
the
fix/parent-watchdog-startup
branch
from
8a8a1ce to
f607c0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes the parent-death watchdog exit immediately from the watchdog thread when the launching process disappears.
The previous path requested graceful shutdown from the watchdog thread. That can leave a stdio server alive long enough to keep the pipe open, and it also runs non-async-safe shutdown work from a thread whose only job is parent-death detection. The new path writes a short diagnostic directly to stderr and calls
_exit(0).The regression test now waits until startup reaches the watchdog-ready point before killing the wrapper, increases the timeout, and treats a zombie child as already exited.
Observed environment: macOS 26.5.2 (25F84), Darwin 25.5.0 arm64, Apple clang 21.0.0. This code path is POSIX-only; Windows remains under the existing
#ifndef _WIN32guard.Test plan
make -f Makefile.cbm build/c/codebase-memory-mcp CC=clang CXX=clang++tests/test_parent_watchdog.sh