Skip to content

Clean cppcheck findings#784

Open
SS-42 wants to merge 1 commit into
DeusData:mainfrom
SS-42:fix/cppcheck-cleanups
Open

Clean cppcheck findings#784
SS-42 wants to merge 1 commit into
DeusData:mainfrom
SS-42:fix/cppcheck-cleanups

Conversation

@SS-42

@SS-42 SS-42 commented Jul 2, 2026

Copy link
Copy Markdown

Summary

  • parse ZIP local-header sizes through explicit little-endian helpers and size_t allocation bounds
  • reject truncated ZIP entries without narrowing 32-bit size fields through int arithmetic
  • remove unreachable null checks in Cypher IS NULL / IS NOT NULL evaluation after the existing null guard

Observed locally on macOS 26.5.2 (Darwin 25.5.0, arm64) with Cppcheck 2.21.0 and Homebrew clang-format 22.1.8.

Tests

  • scripts/lint.sh --ci
  • make -f Makefile.cbm build/c/test-runner CC=clang CXX=clang++
  • ASAN_OPTIONS=detect_leaks=0 ./build/c/test-runner cli cypher

@SS-42 SS-42 requested a review from DeusData as a code owner July 2, 2026 19:19
Signed-off-by: SS-42 <noreply@incogni.to>
@SS-42 SS-42 force-pushed the fix/cppcheck-cleanups branch from d1d8272 to ce1f704 Compare July 2, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant