Skip to content

feature: add death teleport (back to death location#1378

Open
ChudziudgiToJa wants to merge 2 commits into
masterfrom
feature/death-teleport
Open

feature: add death teleport (back to death location#1378
ChudziudgiToJa wants to merge 2 commits into
masterfrom
feature/death-teleport

Conversation

@ChudziudgiToJa

Copy link
Copy Markdown
Contributor

Closes #1333

@ChudziudgiToJa ChudziudgiToJa requested a review from a team as a code owner July 1, 2026 14:58

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new "Death Teleport" feature that automatically teleports players back to their last death location after respawning, complete with configuration settings, database persistence for user toggle states, localization support, and unit tests. The review feedback highlights two important concurrency and safety improvements: addressing a potential race condition in the teleport controller during rapid consecutive deaths (along with checking if the player is still online after asynchronous state retrieval), and safely removing cached toggle states in the service implementation only if they match the failed state to prevent overwriting newer concurrent updates.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ChudziudgiToJa ChudziudgiToJa self-assigned this Jul 1, 2026
@ChudziudgiToJa ChudziudgiToJa added the ✅ needs testing Issue needs verification. label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ needs testing Issue needs verification.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Automatic teleport back to the player’s death location.

1 participant