Conversation
resilience.RetryPolicy retries a fixed attempt count with plain exponential backoff, but can't express a wall-clock deadline (give up after N seconds total) or jitter (randomized backoff against thundering herds). RetryBudget adds both, bounded by attempts and/or a deadline, never sleeping past it; uniform/clock/sleep are injectable so every delay and giveup decision is deterministic in tests.
…-batch Add retry_budget: deadline + jitter over resilience retries
field_entry types and hopes — a slow IME, focus steal, input mask or auto-format can silently drop characters and nothing reads the field back. Distinct from action_effect (any near-target change) and postcondition.text_present (text anywhere). compare_field_value is the pure comparator (exact/trim/ci/normalized/contains); verify_field_value reads via an injectable reader; fill_and_verify types, reads back and retries until it matches.
…-batch Add verify_field: read a field back and confirm the typed value
Hard-coded waits flake either way — too short races a slow machine, too long makes every failure pay the full timeout. Learn the timeout from how long the step actually takes: a high percentile scaled by a safety factor, clamped to a sane band. recommend_timeout is the number to feed a wait/GateConfig; timeout_stats exposes the percentiles and clamp flags. Pure, reuses stats.percentile.
…eout-batch Add adaptive_timeout: derive a wait timeout from observed durations
Acting unconditionally double-toggles an already-checked box or re-enters an already-correct field and can't be safely re-run. ensure_state reads first and only acts (then re-reads to verify) when the state differs; ensure_toggle is the boolean flip specialization. A control already in the desired state is left untouched, so the call is idempotent. Distinct from idempotency (request-key cache) — this converges device state.
…-batch Add ensure_state: idempotent read-compare-act-verify for control state
A click fired while the app is still churning (busy cursor up, dialog mid-paint, long handler running) is dropped or mis-targeted. smart_waits watches pixels settle; this watches the busy signal settle, reusing settle_detector.SettleTracker over a 1.0-busy/0.0-idle series. The busy probe (default Windows busy cursor) and clock/sleep are injectable, so the settle gate is fully testable without an app.
Add app_idle: wait until the app's busy signal settles before acting
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 154 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release — ROUND-15 input-fidelity lane
Five new headless features, each with a pure / injectable-seam core, full 5-layer wiring (facade →
AC_*executor →ac_*MCP → Script Builder), headless tests, and EN/Zh docs. All merged to dev with CI green first try and zero Codacy issues.retry_budget(Add retry_budget: deadline + jitter over resilience retries #436):RetryBudget/run_with_budget— retries bounded by a wall-clock deadline and/or attempts, with full-jitter backoff; injectableuniform/clock/sleep.verify_field(Add verify_field: read a field back and confirm the typed value #437):compare_field_value/verify_field_value/fill_and_verify— read a field back after typing and confirm the value landed (exact/trim/ci/normalized/contains).adaptive_timeout(Add adaptive_timeout: derive a wait timeout from observed durations #438):recommend_timeout/timeout_stats— learn a wait timeout from observed durations (p95×factor, clamped), reusingstats.percentile.ensure_state(Add ensure_state: idempotent read-compare-act-verify for control state #439):ensure_state/ensure_toggle— idempotent read-compare-act-verify so re-runs don't double-toggle;AC_ensure_field_valueover the accessibility value.app_idle(Add app_idle: wait until the app's busy signal settles before acting #440):wait_until_app_idle/idle_point— wait until the app's busy cursor settles, reusingsettle_detector.SettleTracker.Package stays Qt-free; all new logic unit-tested without the OS via injected seams.