feat: add update-major-version-tag reusable composite action#267
Open
Mrtenz wants to merge 4 commits into
Open
feat: add update-major-version-tag reusable composite action#267Mrtenz wants to merge 4 commits into
update-major-version-tag reusable composite action#267Mrtenz wants to merge 4 commits into
Conversation
Replaces the shell script with a composite action so other repos can use it via `uses: MetaMask/github-tools/.github/actions/update-major-version-tag`. Switches from `git push` to the GitHub API so a GitHub App token can be used, enabling tag protection rules that restrict who can push tags.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0d74f23. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The
publish-release.ymlworkflow updated the major version shorthand tag (e.g.,v1) via a shell script that usedgit push. This approach doesn't support tag protection rules, since those require pushes to be authenticated as a specific account or app to bypass the tag protections.This PR replaces the shell script with a reusable composite action at
.github/actions/update-major-version-tagthat calls the GitHub API directly, accepting an explicitgithub-tokeninput. Using a Token Exchange Service token here enables tag protection rules that restrict which actors can create or update tags. The action can also be used by other repos viauses: MetaMask/github-tools/.github/actions/update-major-version-tag.Note
Medium Risk
Changes release automation, token sourcing, and how protected tags are updated; misconfiguration could block releases or fail to move major version tags.
Overview
Release publishing no longer updates the major shorthand tag (e.g.
v1) via a bash script that deleted and re-pushed tags withgit. That flow is replaced by a reusable composite action at.github/actions/update-major-version-tagthat moves the tag with the GitHub REST API (PATCHorPOSTon refs), driven by an explicitgithub-tokenand the publishedrelease-version.The publish-release path is aligned with tag protection: the job uses the
action-publishenvironment, defaultcontents: readplusid-token: write, a get-token step (token exchange withcontents: write), and passes that token toMetaMask/action-publish-releaseand the new tag action. main.yml’s publish job drops broadcontents: writein favor of the same read + id-token pattern for the reusable workflow.Reviewed by Cursor Bugbot for commit 52936db. Bugbot is set up for automated code reviews on this repo. Configure here.