fix: Correct KeyringAccountType values#4057
Merged
Merged
Conversation
KeyringAccountType members
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4057 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 425 425
Lines 12413 12413
Branches 1969 1969
=======================================
Hits 12238 12238
Misses 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hmalik88
previously approved these changes
Jul 1, 2026
hmalik88
previously approved these changes
Jul 1, 2026
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
KeyringAccountType membersKeyringAccountType values
FrederikBolding
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
entropy:accountdoes not exist at all on theaccountsside. I assume this was meant to beany:account(which is a generic account type we can use for dev purposes).Also added
stellar:accountwhich is new account type we now support.Note
Low Risk
Small enum alignment for keyring permissions; removing
entropy:accountcould fail validation for any manifest that still declared it, but that value was never valid on the accounts side.Overview
Aligns
KeyringAccountTypewith@metamask/keyring-apiin@metamask/snaps-sdk(permissions.ts) and@metamask/snaps-utils(KeyringAccountTypeStructinkeyring.ts).Removed the invalid literal
entropy:account. Addedstellar:accountandany:accountso keyring capability typing and manifest/runtime validation accept the account types the accounts stack actually supports.Changelogs for both packages document the fix under [Unreleased].
Reviewed by Cursor Bugbot for commit 96b603c. Bugbot is set up for automated code reviews on this repo. Configure here.