Skip to content

fix: Correct KeyringAccountType values#4057

Merged
ccharly merged 3 commits into
mainfrom
cc/fix/keyring-api-types
Jul 1, 2026
Merged

fix: Correct KeyringAccountType values#4057
ccharly merged 3 commits into
mainfrom
cc/fix/keyring-api-types

Conversation

@ccharly

@ccharly ccharly commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The entropy:account does not exist at all on the accounts side. I assume this was meant to be any:account (which is a generic account type we can use for dev purposes).

Also added stellar:account which is new account type we now support.


Note

Low Risk
Small enum alignment for keyring permissions; removing entropy:account could fail validation for any manifest that still declared it, but that value was never valid on the accounts side.

Overview
Aligns KeyringAccountType with @metamask/keyring-api in @metamask/snaps-sdk (permissions.ts) and @metamask/snaps-utils (KeyringAccountTypeStruct in keyring.ts).

Removed the invalid literal entropy:account. Added stellar:account and any:account so keyring capability typing and manifest/runtime validation accept the account types the accounts stack actually supports.

Changelogs for both packages document the fix under [Unreleased].

Reviewed by Cursor Bugbot for commit 96b603c. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly requested a review from a team as a code owner July 1, 2026 12:37
@ccharly ccharly changed the title fix: fix KeyringAccountType members fix: fix KeyringAccountType members Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (52d3c27) to head (96b603c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4057   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         425      425           
  Lines       12413    12413           
  Branches     1969     1969           
=======================================
  Hits        12238    12238           
  Misses        175      175           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hmalik88
hmalik88 previously approved these changes Jul 1, 2026
hmalik88
hmalik88 previously approved these changes Jul 1, 2026
Comment thread packages/snaps-utils/CHANGELOG.md Outdated
Comment thread packages/snaps-sdk/CHANGELOG.md Outdated
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
@FrederikBolding FrederikBolding changed the title fix: fix KeyringAccountType members fix: Correct KeyringAccountType values Jul 1, 2026
@ccharly ccharly enabled auto-merge July 1, 2026 13:09
@ccharly ccharly added this pull request to the merge queue Jul 1, 2026
Merged via the queue into main with commit 2b3c367 Jul 1, 2026
132 checks passed
@ccharly ccharly deleted the cc/fix/keyring-api-types branch July 1, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants