Fix autotailor overwriting extends attribute from JSON tailoring#2375
Open
Arden97 wants to merge 1 commit into
Open
Fix autotailor overwriting extends attribute from JSON tailoring#2375Arden97 wants to merge 1 commit into
extends attribute from JSON tailoring#2375Arden97 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_profile_idfrom JSON tailoring files when no CLI base profile is providedextendsattribute preservationFix
if args.profile:, so the CLI argument only overridesextendswhen explicitly providedbase_profile_idis preservedTesting hints
autotailor_integration_test.sh, including the newly added one, passed