refactor(agents): unify producers into region-agnostic role (#31)#32
Open
Hackatro wants to merge 1 commit into
Open
Conversation
Collapse _step_bra/_step_usa/_step_arg into one _step_producer. Replace ROLE_BRA/ARG/USA with ROLE_PRODUCER. USA drops its hardcoded surplus_factor and nominal pricing. It is now a plain capacity elastic producer. Trader keys volume by PDL origin instead of the region role, with bra/arg/usa_volume kept as compat view for the current CSV schema + transport (removed in #19)
Sponn
reviewed
Jul 6, 2026
|
|
||
| from .base import SupplyChainAgent | ||
| from .farmer import Farmer, ROLE_BRA,ROLE_ARG, ROLE_USA, ROLE_EU | ||
| from .farmer import Farmer, ROLE_PRODUCER, ROLE_EU |
|
|
||
| # compatibility view for the current CSV schema + transport routing | ||
| # branch 19 removes these three attrs when it refactors transport routing and the output schema off per-region volumes. | ||
| self.bra_volume = volume_by_origin.get("brazil_farms", 0.0) |
Contributor
There was a problem hiding this comment.
Still location based things in the agent implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse _step_bra/_step_usa/_step_arg into one _step_producer. Replace ROLE_BRA/ARG/USA with ROLE_PRODUCER. USA drops its hardcoded surplus_factor and nominal pricing. It is now a plain capacity elastic producer. Trader keys volume by PDL origin instead of the region role, with bra/arg/usa_volume kept as compat view for the current CSV schema + transport (removed in #19)