You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add the missing scheduler invocation in _pthread_cond_timedwait() after the current thread has been suspended, the pthread mutex has been released, and the critical section has been exited.
Root cause
The wait path put the current thread onto the condition semaphore suspend list, but only called rt_exit_critical() before reading thread->error and re-locking the mutex. Without rt_schedule(), the suspended thread could continue running instead of yielding to the scheduler, which breaks pthread condition wait users such as pthread read/write locks.
Scope
This keeps the fix in the condition variable wait implementation, which is the layer that directly suspends the thread. It does not add duplicate scheduling behavior in pthread rwlock callers.
gh search prs 'pthread_cond_timedwait rt_schedule' --repo RT-Thread/rt-thread --state open --limit 20 --json number,title,author,url,isDraft returned no duplicate open PRs.
Tried python -m SCons -n on pthread-enabled BSPs (bsp/mipssim, bsp/microchip/samd51-adafruit-metro-m4), but local cross-toolchain paths are not installed, so BSP build validation could not complete locally.
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!
为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).
设置需排除的文件/目录(目录请以"/"结尾)
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to:codex/fix-pthread-cond-schedule
设置PR number为 \ Set the PR number to:11533
等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.
完成后,提交将自动更新至 codex/fix-pthread-cond-schedule 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the codex/fix-pthread-cond-schedule branch automatically, and the related Pull Request will be updated.
如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add the missing scheduler invocation in
_pthread_cond_timedwait()after the current thread has been suspended, the pthread mutex has been released, and the critical section has been exited.Root cause
The wait path put the current thread onto the condition semaphore suspend list, but only called
rt_exit_critical()before readingthread->errorand re-locking the mutex. Withoutrt_schedule(), the suspended thread could continue running instead of yielding to the scheduler, which breaks pthread condition wait users such as pthread read/write locks.Scope
This keeps the fix in the condition variable wait implementation, which is the layer that directly suspends the thread. It does not add duplicate scheduling behavior in pthread rwlock callers.
Closes #11532
Validation
git diff --checkgh search prs 'pthread_cond_timedwait rt_schedule' --repo RT-Thread/rt-thread --state open --limit 20 --json number,title,author,url,isDraftreturned no duplicate open PRs.python -m SCons -non pthread-enabled BSPs (bsp/mipssim,bsp/microchip/samd51-adafruit-metro-m4), but local cross-toolchain paths are not installed, so BSP build validation could not complete locally.