Skip to content

fix: name anonymous Kconfig choices#11543

Open
CYFS3 wants to merge 1 commit into
RT-Thread:masterfrom
CYFS3:fix-anonymous-kconfig-choice
Open

fix: name anonymous Kconfig choices#11543
CYFS3 wants to merge 1 commit into
RT-Thread:masterfrom
CYFS3:fix-anonymous-kconfig-choice

Conversation

@CYFS3

@CYFS3 CYFS3 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

PR #10643 已经给部分核心组件中的匿名 choice 增加了显式名称,用于避免 kconfiglib 在解析匿名 choice 时产生对象引用不一致相关 warning。

当前仓库中仍有大量 Kconfig 使用匿名 choice,主要分布在 BSP 目录。继续保留匿名 choice 会让后续 Kconfiglib 检查、菜单配置解析和自动化脚本更容易遇到同类问题。

你的解决方案是什么 (what is your solution)

为仓库中剩余的匿名 choice 增加唯一、可读的显式名称。

命名主要基于 BSP 路径和 choice 内 config 符号公共前缀生成,只修改 choice 声明行,不改变 prompt、default、depends、config 选项或实际配置行为。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

    • 根 Kconfig
    • bsp/stm32/stm32f407-atk-explorer
    • bsp/raspberry-pico/RP2040
    • bsp/hpmicro/hpm6800evk
    • bsp/renesas/ra6m4-cpk
    • bsp/nuvoton/numaker-m467hj
    • bsp/ti/c28x/tms320f28379d
    • bsp/bouffalo_lab/bl808/d0
  • .config:

    • 无需修改 .config。本 PR 只为 Kconfig choice 增加显式名称。
  • action:

    • 本地验证:
      • 全仓匿名 choice grep 无匹配
      • git diff --check
      • kconfiglib 解析根 Kconfig,warnings 0
      • kconfiglib 解析多个 BSP 样本;部分 BSP 存在既有 select choice symbol/重复定义类 warning,与本次匿名 choice 命名无关

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:fix-anonymous-kconfig-choice
  • 设置PR number为 \ Set the PR number to:11543
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 fix-anonymous-kconfig-choice 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix-anonymous-kconfig-choice branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: NXP Code related with NXP BSP: STM32 BSP related with ST/STM32 BSP: Loongson BSP related with Loongson BSP BSP: HC32 BSP related with HC32 BSP: ESP32 BSP related with ESP BSP: Renesas BSP related with Renesas BSP: GD32 BSP related with GD32 BSP: Infineon BSP related with Infineon BSP: Cvitek BSP related with cvitek BSP: Phytium BSP related with Phytium BSP: AT32 BSP related with AT32 BSP: WCH BSP related with WCH Component component: drivers/graphic component: drivers/serial component: drivers BSP: Novosns BSP related with novosns labels Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: AT32 BSP related with AT32 BSP: Cvitek BSP related with cvitek BSP: ESP32 BSP related with ESP BSP: GD32 BSP related with GD32 BSP: HC32 BSP related with HC32 BSP: Infineon BSP related with Infineon BSP: Loongson BSP related with Loongson BSP: Novosns BSP related with novosns BSP: NXP Code related with NXP BSP: Phytium BSP related with Phytium BSP: Renesas BSP related with Renesas BSP: STM32 BSP related with ST/STM32 BSP: WCH BSP related with WCH BSP component: drivers/graphic component: drivers/serial component: drivers Component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant