Skip to content

usbdevice: validate string descriptor index#11545

Open
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/fix-usb-string-descriptor-index
Open

usbdevice: validate string descriptor index#11545
Old-Ding wants to merge 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/fix-usb-string-descriptor-index

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Closes #4782

Summary

  • Validate USB string descriptor indices before reading string tables.
  • Return the Microsoft OS string only when an OS compatible ID descriptor has been registered.
  • Stall EP0 for unknown or unregistered string indices instead of reading str_intf out of bounds or dereferencing a null string.

Testing

  • git diff --check origin/master...HEAD
  • Verified the touched file uses CRLF line endings and has no UTF-8 BOM.
  • Not run: RT-Thread build or USB device utest, because this Windows host does not have scons, a C compiler, or an embedded cross toolchain installed.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:codex/fix-usb-string-descriptor-index
  • 设置PR number为 \ Set the PR number to:11545
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 codex/fix-usb-string-descriptor-index 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the codex/fix-usb-string-descriptor-index branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/legacy/usb/usbdevice/core/usbdevice_core.c

📊 Current Review Status (Last Updated: 2026-07-01 16:00 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Old-Ding Old-Ding marked this pull request as ready for review July 1, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_get_string_descriptor in usbdevice_core.c bug

1 participant