feat(ledger): support holon-jsonld report download format#133
Merged
Conversation
download_report_bundle now accepts format="holon-jsonld" — the dataset-form scene/boundary/projection holon the backend materializes on demand at reportDownloadUrl. Maps to the HOLON_JSONLD GraphQL enum name and defaults the on-disk extension to .holon.jsonld.
Pulls through MCPToolsResponse.instructions (per-graph MCP routing guidance) from the current backend schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
holon-jsonlddownload flavor to the Python client and pulls through the latest generated SDK.feat(ledger)— holon-jsonld download (66fb5b5)LedgerClient.download_report_bundle(..., format="holon-jsonld")now resolves the dataset-form holon — the report as#scene/#boundary/#projectionnamed graphs — which the backend materializes on demand atreportDownloadUrl. The facade maps the wire string to theHOLON_JSONLDGraphQL enum name and defaults the on-disk extension to.holon.jsonld. The hand-written facade is preserved by the SDK generator, so this is a small edit, not a regen.chore(sdk)— regenerate from OpenAPI (3d546d8)Regenerated
api/+models/from the current backend spec; the only drift wasMCPToolsResponse.instructions(per-graph MCP routing guidance).Why
Lets Python consumers — including the RoboSystems example demos — natively download the holon from the product endpoint instead of deriving it client-side.
Verification
just test(439 passed, 17 skipped),just typecheck(0 errors), ruff format + lint clean.