Skip to content

chore: Implement skill#757

Merged
ValerianRey merged 3 commits into
SimplexLab:mainfrom
ppraneth:implement-skill
Jun 24, 2026
Merged

chore: Implement skill#757
ValerianRey merged 3 commits into
SimplexLab:mainfrom
ppraneth:implement-skill

Conversation

@ppraneth

Copy link
Copy Markdown
Contributor

Adds skills\implement-method

@ppraneth ppraneth added the cc: chore Conventional commit type for changes to some configuration files of the project. label Jun 23, 2026
@github-actions github-actions Bot changed the title implement skill chore: Implement skill Jun 23, 2026

@ValerianRey ValerianRey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is very good, tyvm!

A few notes:

  • Could you test this skill on a method you've recently implemented? Basically, revert the commit in which you implemented the method, then use the skill to implement it (the row will be missing from the tracker so you'll have to call the research skill too), and see if the proposed implementation by the agent is good enough to serve as a base. If you see problems that can be easily fixed by changing the skill, do that. We don't need the result to be perfect, or to be identical to the implementation that we ended up merging, but we should fix obvious flaws if any.
  • Need an equivalent reference but for aggregators (+ a few examples in step 4 of the skill). @KhusPatel4450, would you be interested in adding that? Otherwise I can try
  • I don't think we'll need a review skill. But I think we should add a code review step after the verify step, just asking the agent to check that everything was respected in the code it produced, and to improve what can be improved.

Comment thread skills/implement-method/references/scalarizers.md Outdated
Comment thread skills/implement-method/SKILL.md Outdated
@ppraneth

Copy link
Copy Markdown
Contributor Author

@ValerianRey I also tested the skills, and they work good.

@ppraneth ppraneth requested a review from ValerianRey June 24, 2026 03:50
@ppraneth ppraneth marked this pull request as ready for review June 24, 2026 14:19
@ppraneth ppraneth requested a review from a team as a code owner June 24, 2026 14:19
@ValerianRey ValerianRey merged commit 1d854be into SimplexLab:main Jun 24, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: chore Conventional commit type for changes to some configuration files of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants