chore: Implement skill#757
Merged
Merged
Conversation
ValerianRey
reviewed
Jun 23, 2026
Member
There was a problem hiding this comment.
I think this is very good, tyvm!
A few notes:
- Could you test this skill on a method you've recently implemented? Basically, revert the commit in which you implemented the method, then use the skill to implement it (the row will be missing from the tracker so you'll have to call the research skill too), and see if the proposed implementation by the agent is good enough to serve as a base. If you see problems that can be easily fixed by changing the skill, do that. We don't need the result to be perfect, or to be identical to the implementation that we ended up merging, but we should fix obvious flaws if any.
- Need an equivalent reference but for aggregators (+ a few examples in step 4 of the skill). @KhusPatel4450, would you be interested in adding that? Otherwise I can try
- I don't think we'll need a review skill. But I think we should add a code review step after the verify step, just asking the agent to check that everything was respected in the code it produced, and to improve what can be improved.
Contributor
Author
|
@ValerianRey I also tested the skills, and they work good. |
ValerianRey
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds skills\implement-method