Skip to content

chore: Add aggregators reference for implement-method skill#758

Merged
ValerianRey merged 3 commits into
SimplexLab:mainfrom
KhusPatel4450:feat/aggregators-skill
Jun 24, 2026
Merged

chore: Add aggregators reference for implement-method skill#758
ValerianRey merged 3 commits into
SimplexLab:mainfrom
KhusPatel4450:feat/aggregators-skill

Conversation

@KhusPatel4450

Copy link
Copy Markdown
Contributor

Covers:

  • Class hierarchy (WeightedAggregator vs GramianWeightedAggregator, _MatrixWeighting vs _GramianWeighting)
  • Paired-class convention and the modifier exception (CR-MOGM pattern)
  • Stateful aggregators: register_buffer, lazy init via _ensure_state, state key rules
  • _NonDifferentiable mixin
  • Property-based validation with standard constraints
  • set_losses setter pattern
  • __repr__ convention
  • Attribution and NOTICES requirements
  • Full file checklist and test checklist
  • Annotated examples by pattern (CR-MOGM, MoDo/SDMGrad, UPGrad)

@KhusPatel4450 KhusPatel4450 requested a review from a team as a code owner June 24, 2026 15:36
@KhusPatel4450 KhusPatel4450 added the cc: chore Conventional commit type for changes to some configuration files of the project. label Jun 24, 2026

@ValerianRey ValerianRey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks! I would just add somewhere that all methods with non-standard usage should also add a usage example in their docstrings explaining how to use the method, but standard methods should not.

Comment thread skills/implement-method/references/aggregators.md Outdated
Comment thread skills/implement-method/references/aggregators.md Outdated
Comment thread skills/implement-method/references/aggregators.md Outdated
@ValerianRey ValerianRey merged commit 47018db into SimplexLab:main Jun 24, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: chore Conventional commit type for changes to some configuration files of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants