chore: Add aggregators reference for implement-method skill#758
Merged
ValerianRey merged 3 commits intoJun 24, 2026
Conversation
ValerianRey
reviewed
Jun 24, 2026
ValerianRey
left a comment
Member
There was a problem hiding this comment.
Very good, thanks! I would just add somewhere that all methods with non-standard usage should also add a usage example in their docstrings explaining how to use the method, but standard methods should not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers:
WeightedAggregatorvsGramianWeightedAggregator,_MatrixWeightingvs_GramianWeighting)register_buffer, lazy init via_ensure_state, state key rules_NonDifferentiablemixinset_lossessetter pattern__repr__conventionNOTICESrequirements