fix: use optimized SQL when selecting non-hidden entries

[racerand]

Summary

This fixes #1239 by rewriting the sqlalchemy code that fetches non-hidden entries. Such that references to the main query are no longer used in the sub-query. This is done in 2 steps:

1. A sub-query that selects all the entry ids with hidden tags by joining TagEntry and Tag.
2. Select all entries where they have that id
   This is done by first querying all tags that are hidden and joining with the TagEntry binding table and selecting only the entry ids.

Previous generated SQL for simple query:

SELECT DISTINCT entries.id
FROM entries
WHERE NOT (EXISTS (SELECT 1 
    FROM tags, tag_entries 
    WHERE entries.id = tag_entries.entry_id AND tags.id = tag_entries.tag_id AND tags.is_hidden)) 
ORDER BY entries.id DESC

New SQL (edited to match current version):

SELECT DISTINCT entries.id 
FROM entries 
WHERE NOT 
    (entries.id IN 
        (SELECT tag_entries.entry_id 
        FROM tag_entries 
        WHERE tag_entries.tag_id IN (SELECT tags.id from tags WHERE tags.is_hidden)) 
ORDER BY entries.id DESC

Tasks Completed

• Platforms Tested:
  • Windows x86
  • Windows ARM
  • macOS x86
  • macOS ARM
  • Linux x86
  • Linux ARM
• Tested For:
  • Basic functionality
  • PyInstaller executable

Reused existing tests, as this should be a "do the same but faster"

[racerand]

After researching the problem, I've come to the conclusion, that while this works well for me, it's not generally true, and ensuring Indices exist for tag_entries might be a more reasonable approach.
Though using explicit joins over implicit ones should still be the preferred approach

[racerand]

I implemented the optimal solution suggested by BobBobs on Discord. In my limited testing both without any hidden and with thousands it appears to perform really well.
The only solution that might perform better is with indices, but I don't think that's necessary to resolve this issue.

[racerand]

I'm fairly certain #1129 will resolve this issue is a much better way

[racerand]

As requested I've reopened this. Though I'm not sure if this is needed when Indices are added

[CyanVoxel]

Thank you for your work on this!