Skip to content

fix(nix): relax send2trash dependency#1326

Closed
Ambossmann wants to merge 1 commit into
TagStudioDev:mainfrom
Ambossmann:fix-nix-relax-send2trash
Closed

fix(nix): relax send2trash dependency#1326
Ambossmann wants to merge 1 commit into
TagStudioDev:mainfrom
Ambossmann:fix-nix-relax-send2trash

Conversation

@Ambossmann

Copy link
Copy Markdown
Contributor

Summary

send2trash has recently increased it's major version to 2 and 2.1.0 has now landed in nixpkgs. This breaks the build as it doesn't fulfil the ~=1.8 constraint in pyproject.toml. From the changelog the only breaking change should be dropped python 2 support, which doesn't affect us.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

send2trash has recently increased it's major version to 2 and 2.1.0 has
now landed in nixpkgs. This breaks the build as it doesn't fulfil the
~=1.8 constraint in pyproject.toml. From the changelog the only breaking
change should be dropped python 2 support, which doesn't affect us.
@TrigamDev TrigamDev added Type: Installation Installing, building, and/or launching the program Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed Type: Fix A fix for a bug, typo, or other issue labels Mar 1, 2026
@CyanVoxel CyanVoxel added the System: Linux For Linux/BSD distributions label Apr 29, 2026
@xarvex

xarvex commented Jul 2, 2026

Copy link
Copy Markdown
Member

Whoops, apologies for missing this, but I have addressed this and rawpy (which also updated recently) in c38fbb0. Thank you regardless!

@xarvex xarvex closed this Jul 2, 2026
@xarvex xarvex removed Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed labels Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

System: Linux For Linux/BSD distributions Type: Fix A fix for a bug, typo, or other issue Type: Installation Installing, building, and/or launching the program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants