Skip to content

fix(release): avoid pre dist tag for prereleases#10986

Open
brenelz wants to merge 1 commit into
TanStack:mainfrom
brenelz:fix/pre-release-dist-tag
Open

fix(release): avoid pre dist tag for prereleases#10986
brenelz wants to merge 1 commit into
TanStack:mainfrom
brenelz:fix/pre-release-dist-tag

Conversation

@brenelz

@brenelz brenelz commented Jun 25, 2026 •
edited by birkskyum
Loading

Copy link
Copy Markdown
Contributor

Removes the explicit pre npm dist-tag from prerelease branch publishing while keeping the GitHub release marked as prerelease.

the tag is set in the pre.json of the -pre branches e.g. beta here:

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted prerelease publishing behavior so release candidates are handled more consistently, reducing the chance of prerelease builds being published with the wrong label.

@brenelz brenelz requested a review from a team as a code owner June 25, 2026 18:11
@coderabbitai

coderabbitai Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The release workflow changes prerelease branch handling in the dist-tag step. *-pre branches now set only prerelease=true, leaving the tag output unset.

Changes

Release prerelease dist-tag

Layer / File(s) Summary
Prerelease output
.github/workflows/release.yml		 The Determine dist-tag step stops setting tag=pre on *-pre branches and keeps prerelease=true as the only output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 I hopped through the release path bright,
pre got tucked away from sight.
One tiny tag, one tiny change,
The moonlit workflow stays in range.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes removing the prerelease npm dist-tag from the release workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR clearly describes the workflow change and motivation, though it omits the checklist and release-impact sections from the template.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7d200f9

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ⛔ Cancelled 3m 38s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-06-25 18:16:10 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jun 25, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10986

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10986

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@10986

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10986

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10986

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10986

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10986

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10986

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10986

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10986

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10986

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10986

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10986

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10986

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10986

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10986

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10986

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10986

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10986

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10986

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10986

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10986

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10986

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10986

commit: 7d200f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@brenelz