feat: initial alpine adapter work#6249
Conversation
|
Important Review skippedToo many files! This PR contains 259 files, which is 109 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (259)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 75337c5
☁️ Nx Cloud last updated this comment at |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
@marceloverdijk This PR is still pretty blank. Were you ever planning to work on it? I've merged the beta branch back in and fixed conflicts. I'm doing some basic updates and having AI finish a basic example, but thenI'd want to hand this back to someone who actually knows alpine |
|
I was also able to get a basic example working after updating the package to the new syntax that we've moved to in beta. Didn't have any issues running the example locally, so hopefully that won't be a blocker anymore @marceloverdijk |
|
Currently I'm using a project "local" adapter implementation which I everytime upgrade to the latest v9 beta; (currently it uses During alpha and beta version I had to update a few times as the API changes (no problem). But I think this is a great start. It's also easier to add more examples or to change the adapter (if needed) once the package is there. |
|
Once merged and the package is released, I'm happy to update my project and start using the "official" adapter ;-) |
|
I'm planning on releasing table v9 as stable in July so wanted to get this and the upcoming Ember one done this week. I can throw an ai agent at it to fill in the rest and then ask for your review |
|
@CodeRabbit review --dir /packages |
|
✅ Action performedReview finished.
|
|
@marceloverdijk I think this adapter is finished. You can test it out in your app with npm i https://pkg.pr.new/TanStack/table/@tanstack/alpine-table@6249 |
|
@KevinVandy I removed the project local alpine adapter from my project and started using All works fine 💪 I'm also using global type customization for meta and custom filter and sort functions. This also work as expected, except in my custom filter functions, the table/column meta data ( |
|
@marceloverdijk You don't need to use declaration merging anymore as of the recent betas: https://tanstack.com/table/beta/docs/framework/react/guide/migrating#filterfns-sortfns-aggregationfns-filtermeta-augmentation-replaced-by-registry-slots
You don't even need declaration merging for table or column meta anymore either
This PR includes documentation for alpine like this: https://tanstack.com/table/beta/docs/guide/table-and-column-meta |


🎯 Changes
✅ Checklist
pnpm test:pr.