fix: ISSN checksum returns 11 instead of 0 when weighted sum is divisible by 11#262
Merged
Merged
Conversation
…ible by 11 The `_calculate_checksum` method in `InternationalStandardSerialNumber` was missing a final `% 11`, causing it to return 11 (an invalid two-digit value) instead of 0 when the weighted digit sum happened to be exactly divisible by 11. Fixes WhyNotHugo#238.
Owner
|
Sounds correct to me. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #238.
The
_calculate_checksummethod inInternationalStandardSerialNumberwas missing a trailing% 11. When the weighted digit sum is exactly divisible by 11, the formula computes11 - 0 = 11— an invalid two-digit value — instead of(11 - 0) % 11 = 0.Before:
After:
Minimal reproduction:
Two regression tests added to
tests/test_checksums.py: one for the zero-checksum case and one confirming theXchecksum case still works.This pull request was prepared with the assistance of AI, under my direction and review.