GH-49231: [C++] Deprecate Feather reader and writer#50321
Conversation
|
|
decb34d to
b1f3eec
Compare
| /// \class Reader | ||
| /// \brief An interface for reading columns from Feather files | ||
| /// | ||
| /// \note Deprecated in 25.0.0. Feather V2 is the Arrow IPC file format; |
There was a problem hiding this comment.
I think it's too late for 25.0.0 as it has been branched by @raulcd already, so you'll have to change all these mentions to 26.0.0 :)
There was a problem hiding this comment.
Done, I've changed all to 26.0.0.
| }; | ||
|
|
||
| /// \note Deprecated in 25.0.0. Feather V2 is the Arrow IPC file format; | ||
| /// use arrow::ipc::MakeFileWriter with arrow::ipc::IpcWriteOptions instead. |
There was a problem hiding this comment.
Also add a ARROW_DEPRECATED macro, or does it just not work here?
There was a problem hiding this comment.
Ok! Added ARROW_DEPRECATED on WriteProperties with commit 59f79c1 and that needed extra suppressions for GCC warnings for default argument in WriteTable and member definition WriteProperties::Defaults(). Also needed for GLib as seen failing on my fork CI job (I couldn't get jobs to run on pr manually, might be because of #50293)
Rationale for this change
See #49231. Deprecate the Feather reader/writer and point users to the Arrow IPC file API.
What changes are included in this PR?
ipc::feather::Reader::Open,ipc::feather::WriteTableand theWritePropertiesstruct marked withARROW_DEPRECATED, pointing users toipc::RecordBatchFileReaderandipc::MakeFileWriter.Deprecation warnings supressed at the internal call sites:
feather.cc,feather_test.cc, the R bindingr/src/feather.cpp(R deprecation is in #49276), and the GLib binding (GLib deprecation is in #49673).Are these changes tested?
-Werrorbuild of arrow-feather-test passes locally.Are there any user-facing changes?
No functional change, compile-time deprecation warning for
feather::Reader::Open,feather::WriteTableor feather::WriteProperties.