KVM: add configurable MAC/IP script hook for static ARP/NDP and routes#13495
KVM: add configurable MAC/IP script hook for static ARP/NDP and routes#13495wido wants to merge 1 commit into
Conversation
Introduces a new agent.properties option `vm.network.macip.script` (absolute path, disabled by default) that BridgeVifDriver invokes on every NIC plug (VM start) and unplug (VM stop). This is very useful in EVPN+VXLAN environments as it can reduce BUM traffic. By setting static ARP/NDP entries bridges can be configured using 'neigh_suppress on' as the ARP/NDP entries are already set statically by CloudStack.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13495 +/- ##
=========================================
Coverage 18.94% 18.94%
- Complexity 18363 18368 +5
=========================================
Files 6192 6192
Lines 556361 556383 +22
Branches 67908 67912 +4
=========================================
+ Hits 105397 105408 +11
- Misses 439393 439400 +7
- Partials 11571 11575 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, why not set your script as default value for the property @wido ? (if it is well tested and robust, that is)
Thanks, the reason the script does not always execute is that it could break existing setups. Therefor it is not set by default. |
yeah, that is what I meant by robust ;) np, fine like this as well. |
Introduces a new agent.properties option
vm.network.macip.script(absolute path, disabled by default) that BridgeVifDriver invokes on every NIC plug (VM start) and unplug (VM stop).This is very useful in EVPN+VXLAN environments as it can reduce BUM traffic. By setting static ARP/NDP entries bridges can be configured using 'neigh_suppress on' as the ARP/NDP entries are already set statically by CloudStack.