fix: gate debug-only assertions in physical planner test test_optimization_invariant_checker

[buraksenn]

Which issue does this PR close?

• Closes physical_planner::tests::test_optimization_invariant_checker fails when run with release-nonlto profile #20786

Rationale for this change

test_optimization_invariant_checker panics under release-nonlto profile which has debug_assertions=false. Thus, we need to gate

What changes are included in this PR?

Make sure debug_assertion required places are behind that gate

Are these changes tested?

Yes and this is test only change.

cargo test physical_planner --profile release-nonlto

now passes since we skip these checks as they are not supported in that profile

Are there any user-facing changes?

No

[xudong963]

How about using cfg!(debug_assertions) which adds an explicit assert!(result.is_ok()) for release mode and removes the need to gate InvariantFailsExtensionNode, giving strictly better coverage with less #[cfg] surface.

[buraksenn]

How about using cfg!(debug_assertions) which adds an explicit assert!(result.is_ok()) for release mode and removes the need to gate InvariantFailsExtensionNode, giving strictly better coverage with less #[cfg] surface.

Thanks, I did not think of this. I've applied it just now