[fix](test) pin variant defaults in check_before_quit#65093
Open
shuke987 wants to merge 2 commits into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_before_quitrecreates tables fromSHOW CREATE TABLE.test_predefine1flatten-nested table in non-doc mode, so the table left byvariant_p0/doc_mode/predefine/load.groovyremains recreate-able bySHOW CREATE TABLE.Failure example:
Found 22 failures during database recreation checksSHOW CREATE TABLEwere recreated as doc-mode properties when the check connection inherited fuzzed variant defaults.Follow-up failure:
Found 1 failures during database recreation checkstest_predefine1haddeprecated_variant_enable_flatten_nested=trueand a laterALTER ADD COLUMNinherited doc mode, producing aSHOW CREATE TABLEstatement rejected by the create path withvariant flatten nested is not enabled, because doc snapshot mode is enabled.Testing
git diff --checkcheck_before_quitdepends on the state left by a full regression pipeline.