Skip to content

[fix](test) pin variant defaults in check_before_quit#65093

Open
shuke987 wants to merge 2 commits into
apache:masterfrom
shuke987:fix-check-before-quit-master
Open

[fix](test) pin variant defaults in check_before_quit#65093
shuke987 wants to merge 2 commits into
apache:masterfrom
shuke987:fix-check-before-quit-master

Conversation

@shuke987

@shuke987 shuke987 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Pin variant session defaults before check_before_quit recreates tables from SHOW CREATE TABLE.
  • Prevent the per-connection session-variable fuzzer from changing omitted variant properties during the create/drop/recreate round trip.
  • This forward-ports the same case-level strategy from branch-4.1: [fix](test) stabilize remaining Cloud-P0/P0/NonConcurrent/External flaky cases (test-only backport rest of #64525) #64613 and additionally pins doc mode for the master failure seen in NonConcurrent build 982802.
  • Keep schema-change columns on the legacy test_predefine1 flatten-nested table in non-doc mode, so the table left by variant_p0/doc_mode/predefine/load.groovy remains recreate-able by SHOW CREATE TABLE.

Failure example:

Follow-up failure:

Testing

  • git diff --check
  • Not run locally; check_before_quit depends on the state left by a full regression pipeline.

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

shuke987 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

@shuke987

shuke987 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants