fix: wait for linux rpc socket on startup#5
Open
ethanndickson wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Occasional slow boots could leave the GUI stuck disconnected because Unix socket connect failed fast and the startup retry budget could exhaust before the system service created
/run/coder-desktop/vpn.sock. Waiting at the transport layer makes startup resilient without a separate retry workaround.How validated
dotnet restore Tests.Vpn/Tests.Vpn.csprojdotnet restore App.Avalonia/App.Avalonia.csprojdotnet test Tests.Vpn/Tests.Vpn.csproj --no-restore -v q— passed, 25 testsdotnet build App.Avalonia/App.Avalonia.csproj --no-restore -v q— passed, with existing Avalonia warnings inDependencyObjectSelector.csRisk / rollback notes
Low risk: the behavior is limited to Linux RPC startup. If the service socket never appears, connection waits until the app shuts down or the caller cancels, which matches the intended Windows behavior. Roll back by reverting the transport wait loop and restoring bounded startup retries.