fix: honor disabled proxy support for proxy settings#1019
Merged
Conversation
beaf091 to
ebae812
Compare
code-asher
approved these changes
Jun 30, 2026
Update coder.proxyBypass description and deprecate it toward http.noProxy, and call out the breaking change in the changelog.
97b1cab to
acd6c6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http.proxySupportisoff.http.proxySupport: offbehavior to Coder API HTTP, WebSocket, and SSE paths by ignoring VS Code-derived proxy settings and proxy authorization.http.proxySupportso disconnected WebSocket streams reconnect with updated proxy behavior, and SSH sessions prompt for reload when it changes.Fixes #1017
Tests
pnpm test:extension ./test/unit/api/utils.test.ts ./test/unit/api/coderApi.test.ts ./test/unit/remote/environment.test.tspnpm test:extensionpnpm format:check CHANGELOG.md src/remote/environment.ts test/unit/remote/environment.test.ts src/api/utils.ts src/api/coderApi.ts test/unit/api/utils.test.ts test/unit/api/coderApi.test.tspnpm typecheckpnpm lintInvestigation notes
Issue #1017 is a regression from the v1.15.1 fix for #1010. The extension started translating VS Code proxy settings into
HTTP_PROXY/HTTPS_PROXY/NO_PROXYfor thecoder sshProxyCommand, but only readhttp.proxy,http.noProxy, andcoder.proxyBypass.VS Code's
http.proxySupportsetting includesoff, which means extension proxy support is disabled. With this patch,http.proxySupport: "off"disables only VS Code-derived proxy env/config injection. Existing process env proxy variables remain untouched, matching the selected remediation path.For Coder API traffic, HTTP requests use
createHttpAgentvia Axios interceptors; WebSockets pass the same agent tows; SSE fallback uses the same Axios instance through the streaming fetch adapter. Therefore the sharedcreateHttpAgentbehavior covers HTTP, WebSocket, and SSE connections.workbench.browser.enableRemoteProxywas checked but is specific to VS Code browser/tunnel proxy behavior, not the SSH ProxyCommand or Coder API client.Generated by Coder Agents.