Add examples for local testing and CI/CD lifecycle management#36
Open
Martijn Visser (MartijnVisser) wants to merge 1 commit into
Open
Add examples for local testing and CI/CD lifecycle management#36Martijn Visser (MartijnVisser) wants to merge 1 commit into
Martijn Visser (MartijnVisser) wants to merge 1 commit into
Conversation
c55ba3c to
54960f8
Compare
54960f8 to
b37ae89
Compare
| ENV_ID: ${{ secrets.ENV_ID }} | ||
| COMPUTE_POOL_ID: ${{ secrets.COMPUTE_POOL_ID }} | ||
| # Group lifecycle operations under the same application name used at deploy time. | ||
| APPLICATION_NAME: marketplace-analytics |
There was a problem hiding this comment.
Can we move this to action inputs? In a real world scenario you will probably want to re-use this action for all applications you might own
| String finalName = ConfluentTools.getStatementName(insertIntoResult); | ||
|
|
||
| System.out.println("Statement has been deployed as: " + finalName); | ||
| private static String requireEnv(String name) { |
There was a problem hiding this comment.
I think we should not include this function here. All of the other examples have no checks whether the given database and catalog are existent and follow the same pattern of having variables for them at the top. Sticking to the same patterns across examples helps a user to focus on the more important parts.
3e6dd1d to
20f491e
Compare
20f491e to
41b85c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures the integration and deployment example around a realistic developer workflow and adds local testing and CI/CD lifecycle management:
Verified: ./mvnw clean verify -DskipITs passes offline (4 unit tests green), verify without credentials fails fast with the expected message, the shaded JAR is unaffected by the test dependencies (no OSS planner classes or service entries), and the integration test has been executed successfully against a live Confluent Cloud environment.