fix(cli): dedupe userRules from config and markdown rule sources#12926
Open
syf2211 wants to merge 2 commits into
Open
fix(cli): dedupe userRules from config and markdown rule sources#12926syf2211 wants to merge 2 commits into
syf2211 wants to merge 2 commits into
Conversation
Fixes continuedev#12925 Markdown rules from .continue/rules were merged into the CLI system prompt twice: once via ConfigService into config.rules and again in constructSystemMessage. Incomplete deduplication also allowed identical rules from project and global directories to appear multiple times. Use appendUniqueRuleContents when building processedRules, dedupe rule bodies while scanning rule directories, and skip duplicate markdown entries when ConfigService merges rules into config.
dosubot
Bot
added
the
size:M
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
- Group sibling imports together in systemMessage.test.ts - Extract parseAlwaysApplyMarkdownRule helper to reduce nesting depth
dosubot
Bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes duplicate
.continue/rulescontent in the Continue CLI system promptuserRulesblock.Motivation
Fixes #12925. When using the Continue CLI, markdown rules from
.continue/rules/were rendered twice in the model context. This happened because markdown rules were merged intoconfig.rulesinConfigService, then loaded again inconstructSystemMessage(), and deduplication did not cover duplicate entries already present in config or identical rules found in both project and global rule directories.Changes
appendUniqueRuleContents()and use it when merging config rules and markdown fallback rules inconstructSystemMessage().continue/rulesdirectories inloadMarkdownRulesWithMetadata()ConfigServicemerges rules into configTests
npx vitest run src/systemMessage.test.ts— 24 passednpx vitest run src/services/ConfigService.test.ts— 24 passedNotes
Composer-2.5 review: APPROVE. Minimal, focused CLI-only change; no behavior change for distinct rule bodies.
Summary by cubic
Deduplicates CLI
userRulesso markdown rules from.continue/rulesaren’t repeated in the system prompt. Fixes #12925 by removing duplicates across config, project, and global rule sources.ConfigServiceandconstructSystemMessage()usingappendUniqueRuleContents().loadMarkdownRulesWithMetadata(); extractparseAlwaysApplyMarkdownRule()to reduce nesting and satisfy ESLint max-depth.Written for commit 9279b89. Summary will update on new commits.