acc: run generate/auto-bind locally on all clouds#5766
Merged
Conversation
Collaborator
Integration test reportCommit: 2fdc31f
21 interesting tests: 13 SKIP, 7 KNOWN, 1 RECOVERED
|
denik
approved these changes
Jun 29, 2026
a2bb094 to
bfd7066
Compare
Flip bundle/generate/auto-bind to Local = true so it runs against the local testserver in addition to cloud. The test imports a notebook via the workspace import API and then generates, binds, deploys and destroys a job from it. The fake workspace now models the notebook-import behavior, so the local run produces output identical to cloud with no testserver changes and the stale comment explaining why it could not run locally is removed.
bfd7066 to
2fdc31f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Flip
acceptance/bundle/generate/auto-bindtoLocal = trueso it runs against the local testserver in addition to cloud.The test imports a notebook through the workspace import API and then generates, binds, deploys and destroys a job from it. The fake workspace already models the notebook-import behavior, so the local run produces output identical to cloud with no testserver changes. The stale comment claiming this could not run locally is removed.
Why
Local tests are better.
Tests
No additional tests.