Add --ssh-jump CLI argument#1986
Open
rolandwalker wants to merge 1 commit into
Open
Conversation
restoring functionality removed in v2.0.0, under a different interface, and with a different internal implementation. In the new interface, there is a single argument --ssh-jump, which accepts values in the form user@host:port. Cleartext SSH passwords on the CLI are no longer accepted. The user will be prompted for a password if the connection is not otherwise configured. Deprecated arguments such as --ssh-host now refer to --ssh-jump. Remote sockets are accepted. A keyring field is added for the ssh-jump value, if any, but it is not appended unless present, so existing keyring values are not invalidated. The internals are completely different: instead of using complex Python libraries (paramiko/sshtunnel) we simply open a tunnel using the ssh executable in a thread.
rolandwalker
force-pushed
the
RW/ssh-jump-restore
branch
from
1d78f87 to
a6ef717
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
--ssh-jumpCLI argument, restoring functionality removed in v2.0.0, under a different interface, and with a different internal implementation.In the new interface, there is a single argument
--ssh-jump, which accepts values in the form user@host:port. Cleartext SSH passwords on the CLI are no longer accepted. The user will be prompted for a password if the connection is not otherwise configured.Deprecated arguments such as
--ssh-hostnow refer to--ssh-jump.Remote sockets are accepted.
A keyring field is added for the ssh-jump value, if any, but it is not appended unless present, so existing keyring values are not invalidated.
The internals are completely different: instead of using complex Python libraries (paramiko/sshtunnel) we simply open a tunnel using the
sshexecutable in a thread.Fixes #1960.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).