static: Use hyphen as version separator in archive names#462
Draft
vvoland wants to merge 2 commits into
Draft
Conversation
Previously the tgz/zip archives contained a named subdirectory (e.g. containerd.io/, docker-buildx/, docker-compose/), requiring users to cd into it after extraction. Change the tar and zip commands to archive from inside the staging directory so all files (binaries, LICENSE, README.md) land directly at the archive root. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Change archive filenames from `pkgname_version` to `pkgname-version` (e.g. containerd-1.2.3.tgz instead of containerd_1.2.3.tgz) across all pkg-static-build.sh scripts. This matches current download.docker.com naming Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change archive filenames from
pkgname_versiontopkgname-version(e.g. containerd-1.2.3.tgz instead of containerd_1.2.3.tgz) across all pkg-static-build.sh scripts.This matches current download.docker.com naming