Skip to content

✏️ Fix unclosed anchor tag in README badges#442

Open
GinaShome wants to merge 1 commit into
fastapi:mainfrom
GinaShome:fix-readme-anchor-tag
Open

✏️ Fix unclosed anchor tag in README badges#442
GinaShome wants to merge 1 commit into
fastapi:mainfrom
GinaShome:fix-readme-anchor-tag

Conversation

@GinaShome

Copy link
Copy Markdown

Pull Request

Discussion:

Description

Fixes an unclosed anchor tag in the README badge section. This ensures the HTML is properly formed.

AI Disclaimer

AI transcript

Checklist

  • [ x] This PR is an obvious typo fix, or it links to a GitHub Discussion for the proposed code change.
  • I added tests for the change.
  • The new or updated tests fail on the main branch and pass on this PR.
  • Coverage stays at 100%.
  • [x ] The documentation explains the change if needed.

@github-actions github-actions Bot added the docs Improvements or additions to documentation label Jun 24, 2026
@svlandeg svlandeg changed the title Fix unclosed anchor tag in README badges ✏️ Fix unclosed anchor tag in README badges Jun 25, 2026

@svlandeg svlandeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GinaShome , thanks for the PR! That does look like a little typo in the readme.

Actually, we might have the same mistake in other repo's as well, I see for instance the same on Typer.

Then again, it actually looks like this coverage badge isn't working properly. On any of our repos, it gives me "No items found using the specified filter." 🤔 Let us look into this as a separate issue before we make further decisions here.

@GinaShome

Copy link
Copy Markdown
Author

Ah, I think I found what may be happening. The coverage report is 100%, so if "hide covered" is checked, all rows are hidden and the report shows "No items found using the specified filter." That message is the report's empty-state UI when there aren't any rows to display.

The checkbox state also seems to persist when reopening Smokeshow reports, which might be making it look empty. When I uncheck "hide covered," the coverage rows show up again, and the badge SVG itself returns coverage: 100%.

@svlandeg

Copy link
Copy Markdown
Member

Oh, you're right! Of course 🥲 That said, we're still internally discussing whether we'll be keeping this particular badge, will get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants