✏️ Fix unclosed anchor tag in README badges#442
Conversation
There was a problem hiding this comment.
Hi @GinaShome , thanks for the PR! That does look like a little typo in the readme.
Actually, we might have the same mistake in other repo's as well, I see for instance the same on Typer.
Then again, it actually looks like this coverage badge isn't working properly. On any of our repos, it gives me "No items found using the specified filter." 🤔 Let us look into this as a separate issue before we make further decisions here.
|
Ah, I think I found what may be happening. The coverage report is 100%, so if "hide covered" is checked, all rows are hidden and the report shows "No items found using the specified filter." That message is the report's empty-state UI when there aren't any rows to display. The checkbox state also seems to persist when reopening Smokeshow reports, which might be making it look empty. When I uncheck "hide covered," the coverage rows show up again, and the badge SVG itself returns coverage: 100%. |
|
Oh, you're right! Of course 🥲 That said, we're still internally discussing whether we'll be keeping this particular badge, will get back to you. |
Pull Request
Discussion:
Description
Fixes an unclosed anchor tag in the README badge section. This ensures the HTML is properly formed.
AI Disclaimer
AI transcript
Checklist