Update to RapidJSON 1.1.0#79
Open
fingolfin wants to merge 1 commit into
Open
Conversation
fingolfin
force-pushed
the
mh/rapidjson-update
branch
from
0cf927c to
9441d7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 69.08% 69.33% +0.24%
==========================================
Files 15 15
Lines 922 936 +14
==========================================
+ Hits 637 649 +12
- Misses 285 287 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not particularly invested in this PR; the change was a first attempt to fix the warning that ultimately was resolved by PR #75.
I don't really know whether RapidJSON 1.1.0 has any useful new stuff or fixes. Anyway, since I figured since I already invested the work, I might as well let you decide whether to merge or drop it (no hard feelings either way :-).