ref(deno): add deno-integration-tests dev-package#21827
Open
isaacs wants to merge 1 commit into
Open
Conversation
isaacs
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Move the 'mysql' devDep out of the deno SDK (since we'll have many more to follow in short order) in favor of a deno-integration-tests package, similar to node-integration-tests and bun-integration-tests.
isaacs
force-pushed
the
isaacs/deno-integration-tests
branch
from
ed4e650 to
54823eb
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 54823eb. Configure here.
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "extends": "../../tsconfig.json", | |||
| "include": ["./lib.deno.d.ts", "suites/**/*"], | |||
There was a problem hiding this comment.
Missing Deno types before lint
High Severity
The integration package tsconfig.json includes gitignored lib.deno.d.ts, but CI job_lint runs root yarn lint without ever running this package’s deno-types script. @sentry/deno gets that file during job_build via build:transpile; this dev-package has no equivalent step, so type-aware lint can fail on Deno globals and missing include files.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 54823eb. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the 'mysql' devDep out of the deno SDK (since we'll have many more to follow in short order) in favor of a deno-integration-tests package, similar to node-integration-tests and bun-integration-tests.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
Note: conflicts somewhat with #21826, but easy enough to just move the deno-pg test into place, either on that PR or this one, depending on what lands first.