chore(spanner): migrate to std::optional#16201
Open
colinmoy wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modernizes the Spanner client library by replacing the use of absl::optional and absl::nullopt with the C++17 standard library equivalents std::optional and std::nullopt across all source files, headers, tests, and samples. I have no feedback to provide as there are no review comments to assess.
colinmoy
force-pushed
the
migrate-spanner-optional
branch
from
ded609d to
275ecbd
Compare
colinmoy
force-pushed
the
migrate-spanner-optional
branch
from
275ecbd to
48c0618
Compare
scotthart
approved these changes
Jun 25, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16201 +/- ##
==========================================
- Coverage 92.24% 92.24% -0.01%
==========================================
Files 2265 2265
Lines 210126 210125 -1
==========================================
- Hits 193839 193831 -8
- Misses 16287 16294 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing explicit usages of absl::optional with std::optional in the Spanner Client library as part of broader modernization efforts