feat(uploads): harden multipart uploads to sdk-rust parity#133
Open
zfarrell wants to merge 3 commits into
Open
feat(uploads): harden multipart uploads to sdk-rust parity#133zfarrell wants to merge 3 commits into
zfarrell wants to merge 3 commits into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thorough review complete. The re-sweep driver, per-part stall watchdog, streaming JIT-mint path, unified error hierarchy, and top-level exports are all correct, internally consistent, and backed by comprehensive tests (streaming serialization, mid-flight cancellation, exhausted-marking, watchdog scheduling/pool-restamping, error wrapping). No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings sdk-python's presigned upload path to feature and ergonomic parity with sdk-rust: whole-upload re-sweep with per-part stall cancellation, two-tier retry, streaming JIT-mint for large files (>8 MiB), a 30s storage connect timeout, and a unified
UploadErrorhierarchy withcancel_event,request_timeout, anexhaustedmarker, and a thread-safetqdm_progressadapter. Validated by a three-agent review (adversarial parity, UX build-through, test-coverage matrix).