[test do not merge] snapshot golden tests#1446
Draft
ludfjig wants to merge 2 commits into
Draft
Conversation
ludfjig
added
regen-goldens
ludfjig
force-pushed
the
snapshot-golden-tests
branch
2 times, most recently
from
db6f7fb to
b5a0b52
Compare
ludfjig
force-pushed
the
snapshot-golden-tests
branch
5 times, most recently
from
e8bcea9 to
0115ba2
Compare
ludfjig
added
the
kind/enhancement
ludfjig
force-pushed
the
snapshot-golden-tests
branch
4 times, most recently
from
cc3dfd6 to
6ec0bbf
Compare
A guest exception handler runs on the IST1 stack. If the handler writes a copy-on-write page, the first write faults. The page fault also uses IST1, so the CPU resets RSP to the top of IST1 and writes the fault frame over the live handler frame. The handler returns to a bad address and the guest aborts. The test exception handler increments a counter that starts on a copy-on-write page. Write the counter once in install_handler so its page copies into scratch before the handler runs. The handler then increments a writable page and does not fault. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
snapshot-golden-tests
branch
from
6ec0bbf to
22a0cff
Compare
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
snapshot-golden-tests
branch
from
22a0cff to
0658445
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests to help notice breaking changes in the guest<->host ABI. This matters because any change there breaks every snapshot already persisted to disk (bad!).
When a change to the format is intentional, the author bumps the version and applies the
regen-goldenslabel. A workflow then regenerates the goldens against the branch and pushes the new set to GHCR.See docs/snapshot-versioning.md for details.