Add --rescan-from-height CLI argument#196
Conversation
|
👋 Hi! This PR is now in draft status. |
Use the latest LDK Node main revision now that wallet recovery support has landed upstream. Keep ldk-server compiling across the dependency's API changes so the remaining branch commits can focus on startup flags. Co-Authored-By: HAL 9000
Expose a startup option for bitcoind-backed wallet recovery without silently accepting unsupported chain sources. Pass the height through to LDK Node only when the bitcoind RPC chain source is configured. Co-Authored-By: HAL 9000
Expose a startup option for Electrum and Esplora wallet recovery without accepting it for bitcoind RPC. Pass the request through LDK Node sync config so a full scan is forced until one succeeds. Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-04-rescan-from-height-arg
branch
from
bc347e8 to
879e589
Compare
benthecarman
left a comment
benthecarman
left a comment
There was a problem hiding this comment.
I see you excluded these from the toml config, makes sense because its not really something you set persistently, just for a single run. Should we exclude the env variations for these too then? Env variables feel similar to me but maybe that's just my systemd preference coming out
| if self.force_wallet_full_scan { | ||
| return Err(io::Error::new( | ||
| io::ErrorKind::InvalidInput, | ||
| "`--force-wallet-full-scan` requires the Electrum or Esplora chain source.", |
There was a problem hiding this comment.
we should reference rescan-from-height in this error message
There was a problem hiding this comment.
Hmm, could you expand what you're thinking of there? Seems they are slightly orthogonal, so not sure why we need the cross-referencing?
| if self.rescan_from_height.is_some() { | ||
| return Err(io::Error::new( | ||
| io::ErrorKind::InvalidInput, | ||
| "`--rescan-from-height` requires the bitcoind RPC chain source.", |
There was a problem hiding this comment.
we should reference --force-wallet-full-scan in this error message
| if self.rescan_from_height.is_some() { | ||
| return Err(io::Error::new( | ||
| io::ErrorKind::InvalidInput, | ||
| "`--rescan-from-height` requires the bitcoind RPC chain source.", |
3 participants
Based on lightningdevkit/ldk-node#884
We expose
--rescan-from-heightand--force-wallet-full-scanCLI arguments. First we bump the LDK Node dependency though, to include the changes from #884.