Fully stabilize now-stable protocol properties#1686
Merged
Conversation
… plumbing) Removes the internal *Core JSON plumbing from ClientCapabilities.Extensions, ServerCapabilities.Extensions, RequestParams.InputResponses, and RequestParams.RequestState, converting them to plain public [JsonPropertyName] auto-properties. PR #1642 removed [Experimental] from these but left the workaround plumbing from #1301, so consumer-defined source-gen contexts still silently dropped them. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
eiriktsarpalis
requested review from
PranavSenthilnathan,
halter73 and
jeffhandley
PranavSenthilnathan
approved these changes
Jul 1, 2026
eiriktsarpalis
added a commit
to eiriktsarpalis/runtime
that referenced
this pull request
Jul 3, 2026
…bers The System.Text.Json source generator supports inaccessible members via UnsafeAccessor (net8+) or a reflection fallback (.NET Framework). Support for inaccessible members annotated with [JsonInclude] was intentionally disabled in dotnet#124650 because a workaround in the MCP SDK relied on the omission. That dependency has since been removed (modelcontextprotocol/csharp-sdk#1686), so this re-enables full support. - The parser no longer forces HasJsonInclude = false for inaccessible [JsonInclude] members and no longer reports SYSLIB1038. - The SYSLIB1038 diagnostic descriptor and its resx/xlf strings are removed; the diagnostic ID remains documented so it is never reused. - Behavior tests now assert full round-trip support uniformly across reflection and source-gen; the disabled-behavior source-gen overrides are removed and the UnsafeAccessors_PrivateProperties baselines are regenerated for both netcoreapp (UnsafeAccessor) and net462 (reflection). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1301 hid experimental JSON properties from consumer source generators using an internal
*Coretwin pattern (public[JsonIgnore]+ internal[JsonInclude]). #1642 later removed[Experimental]fromClientCapabilities.Extensions,ServerCapabilities.Extensions,RequestParams.InputResponses, andRequestParams.RequestStatebut left that plumbing in place — so consumer-definedJsonSerializerContexts still silently dropped these now-stable properties.This removes the
*Coretwins and converts the four properties to plain public[JsonPropertyName]auto-properties. Wire format is unchanged; consumer source-gen contexts now round-trip them correctly.ExperimentalPropertySerializationTests.csis deleted because it asserted the #1301 drop-by-consumer-context behavior, which no longer applies.