Skip to content

feat(card): upload images pasted from the clipboard as attachments#8042

Open
SadeqRouhani wants to merge 1 commit into
nextcloud:mainfrom
SadeqRouhani:feat/paste-image-attachments
Open

feat(card): upload images pasted from the clipboard as attachments#8042
SadeqRouhani wants to merge 1 commit into
nextcloud:mainfrom
SadeqRouhani:feat/paste-image-attachments

Conversation

@SadeqRouhani

Copy link
Copy Markdown
Contributor
  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: sadegh <sa.rohani72@gmail.com>
const extension = extensions[file.type] ?? (file.type.split('/')[1] ?? 'png')
const d = new Date()
const pad = (n) => String(n).padStart(2, '0')
const stamp = `${d.getFullYear()}${pad(d.getMonth() + 1)}${pad(d.getDate())}-${pad(d.getHours())}${pad(d.getMinutes())}${pad(d.getSeconds())}`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ignore duplicate, it should be

const stamp = `${d.getFullYear()}${pad(d.getMonth() + 1)}${pad(d.getDate())}-${d.getTime()}`

'image/bmp': 'bmp',
'image/svg+xml': 'svg',
}
const extension = extensions[file.type] ?? (file.type.split('/')[1] ?? 'png')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should extract file extension from file name instead

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants