Skip to content

Relax reflection constraints #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mingxwa wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −7
Open

Relax reflection constraints #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/spec/ProBasicReflection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ A type `R` meets the *ProBasicReflection* requirements if the following expressi
| Expressions | Semantics |
| ---------------------------- | ------------------------------------------------------------ |
| `R::is_direct` | A [core constant expression](https://en.cppreference.com/w/cpp/language/constant_expression) of type `bool`, specifying whether the reflection applies to a pointer type itself (`true`), or the element type of a pointer type (`false`). |
| `typename R::reflector_type` | A type that defines the data structure reflected from the type. Shall be *nothrow-default-constructible* and *nothrow-destructible*. |
| `typename R::reflector_type` | A type that defines the data structure reflected from the type. |

## See Also

Expand Down
2 changes: 1 addition & 1 deletion docs/spec/ProReflection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ A type `R` meets the *ProReflection* requirements of a type `P` if `R` meets the

| Expressions | Semantics |
| --------------------------------------------------- | ------------------------------------------------------------ |
| `typename R::reflector_type(std::in_place_type<T>)` | A [core constant expression](https://en.cppreference.com/w/cpp/language/constant_expression) that constructs a value of type `typename R::reflector_type`, reflecting implementation-defined metadata of type `T`. |
| `typename R::reflector_type(std::in_place_type<T>)` | Constructs a value of type `typename R::reflector_type`, reflecting implementation-defined metadata of type `T`. |

## See Also

Expand Down
6 changes: 2 additions & 4 deletions include/proxy/v4/detail/core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,9 +470,7 @@ template <class T, bool IsDirect, class R>
consteval bool is_reflector_well_formed() {
if constexpr (IsDirect) {
if constexpr (std::is_constructible_v<R, std::in_place_type_t<T>>) {
if constexpr (is_consteval([] { return R(std::in_place_type<T>); })) {
return true;
}
return true;
}
} else {
return is_reflector_well_formed<
Expand Down Expand Up @@ -745,7 +743,7 @@ struct meta_ptr_indirect_impl {
private:
const M* ptr_;
template <class P>
static constexpr M storage{std::in_place_type<P>};
static inline const M storage{std::in_place_type<P>};
};
template <class M, class DM>
struct meta_ptr_direct_impl : private M {
Expand Down
2 changes: 1 addition & 1 deletion tests/proxy_traits_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ struct RuntimeReflection {
struct FacadeWithRuntimeReflection : pro::facade_builder //
::add_reflection<RuntimeReflection> //
::build {};
static_assert(!pro::proxiable<MockTrivialPtr, FacadeWithRuntimeReflection>);
static_assert(pro::proxiable<MockTrivialPtr, FacadeWithRuntimeReflection>);

struct FacadeWithTupleLikeConventions {
struct ToStringConvention {
Expand Down
Loading