feat: add RPM-only build mode for presubmit CI

[agullon]

Summary

• Add -rpm_only flag to ci_phase_iso_build.sh that skips composer config and image builds, only building RPMs
• Skip manage_composer_config.sh create when running in RPM-only mode
• Move rpm-install scenarios from scenarios-bootc/ to scenarios-rpm/

Context

Shift Week project: RPM-based presubmit CI reduces total CI time from ~55 min to ~30-35 min (~35-40% faster) by eliminating the image build phase for scenarios that don't need ostree/bootc deployment.

Test plan

• Run ci_phase_iso_build.sh -rpm_only and verify it exits after build_rpms.sh
• Verify existing (non-rpm_only) builds are unaffected
• End-to-end RPM presubmit run with converted scenarios

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added an -rpm_only command-line option to run an RPM-focused build and stop after RPM package creation.
• Bug Fixes
  • Improved RPM-only mode to bypass cache-related logic and skip later image/bootc build steps.
  • For RPM presubmit scenarios, mirror registry setup is now conditionally skipped to avoid unnecessary work.
• Chores
  • Reduced GNU Parallel citation output noise during RPM builds by using a will-cite marker instead of invoking citation output.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [agullon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Adds RPM-only build handling in ci_phase_iso_build.sh, skips mirror-registry startup for matching presubmits, and changes build_rpms.sh to prepare GNU Parallel citation state with a file.

Changes

RPM-only CI flow

Layer / File(s)	Summary
RPM-only build selection test/bin/ci_phase_iso_build.sh	Recognizes -rpm_only, disables composer CLI builds, and runs ./bin/build_rpms.sh instead of the image and bootc build flow.
Mirror registry gating test/bin/ci_phase_boot_and_test.sh, test/bin/scenario.sh	Sets SKIP_MIRROR_REGISTRY=true for RPM-only presubmits and checks that flag before starting mirror_registry.sh.
Parallel citation file setup test/bin/build_rpms.sh	Creates ~/.parallel/will-cite before running parallel build jobs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding an RPM-only build mode for presubmit CI.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Touched files are shell/scenario scripts only; no It/Describe/Context/When test titles were added or changed.
Test Structure And Quality	✅ Passed	No Ginkgo test code was modified; the PR only changes shell scripts and scenario scripts, with no *_test.go files or Describe/It blocks touched.
Microshift Test Compatibility	✅ Passed	The PR only changes shell/scenario scripts; no new Ginkgo It/Describe tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only changes shell scripts; no Go/Ginkgo test declarations or SNO-unsafe test logic were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CI/test shell scripts changed; no manifests, operators, controllers, or scheduling constraints were introduced.
Ote Binary Stdout Contract	✅ Passed	PR only changes CI shell scripts; no OTE binary main/init/test setup code writes to stdout were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The PR only changes shell orchestration and scenario routing; it adds no new Ginkgo tests or IPv4-sensitive test code.
No-Weak-Crypto	✅ Passed	Touched scripts only add rpm-only branching and mirror-registry env handling; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges	✅ Passed	PASS: The PR only changes shell scripts/scenario placement; no container/K8s manifests were added or modified with privileged settings.
No-Sensitive-Data-In-Logs	✅ Passed	Touched lines only add RPM-only branching and parallel citation suppression; no new logging of secrets, tokens, PII, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/bin/ci_phase_boot_and_test.sh`:
- Around line 56-59: Reset SKIP_MIRROR_REGISTRY before the scenario branching in
ci_phase_boot_and_test.sh so inherited values do not leak into non-RPM jobs.
Update the pre-submit logic around the SCENARIO_TYPE and SCENARIO_SOURCES checks
to initialize SKIP_MIRROR_REGISTRY to false (or explicitly clear it) before
setting it to true for the rpm-presubmits path, and ensure the non-RPM branches
leave it disabled so scenario.sh sees the correct value.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5ef256d2-d333-4097-a80d-9ac3d8a2059d

📥 Commits

Reviewing files that changed from the base of the PR and between 69eca43 and d7b5067.

📒 Files selected for processing (2)

• test/bin/ci_phase_boot_and_test.sh
• test/bin/scenario.sh

[coderabbitai]

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

Reset SKIP_MIRROR_REGISTRY before branching.

This only exports true on the RPM-only path. Since scenario.sh now reads the inherited environment, a caller that already has SKIP_MIRROR_REGISTRY=true will also skip mirror setup for non-RPM jobs. Initialize it to false first, or clear it in the non-RPM branches.

Suggested fix

+# Default for all scenarios; override only for RPM-only presubmits.
+export SKIP_MIRROR_REGISTRY=false
+
 # RPM-only presubmits skip the mirror registry — scenarios pull images directly.
 if [[ "${SCENARIO_TYPE:-}" =~ ^rpm-presubmits-.*$ ]]; then
     export SKIP_MIRROR_REGISTRY=true
 elif [[ "${SCENARIO_SOURCES:-}" =~ .*releases.* ]]; then

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	# RPM-only presubmits skip the mirror registry — scenarios pull images directly.
	if [[ "${SCENARIO_TYPE:-}" =~ ^rpm-presubmits-.*$ ]]; then
	export SKIP_MIRROR_REGISTRY=true
	elif [[ "${SCENARIO_SOURCES:-}" =~ .*releases.* ]]; then
	# Default for all scenarios; override only for RPM-only presubmits.
	export SKIP_MIRROR_REGISTRY=false
	# RPM-only presubmits skip the mirror registry — scenarios pull images directly.
	if [[ "${SCENARIO_TYPE:-}" =~ ^rpm-presubmits-.*$ ]]; then
	export SKIP_MIRROR_REGISTRY=true
	elif [[ "${SCENARIO_SOURCES:-}" =~ .*releases.* ]]; then

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/bin/ci_phase_boot_and_test.sh` around lines 56 - 59, Reset
SKIP_MIRROR_REGISTRY before the scenario branching in ci_phase_boot_and_test.sh
so inherited values do not leak into non-RPM jobs. Update the pre-submit logic
around the SCENARIO_TYPE and SCENARIO_SOURCES checks to initialize
SKIP_MIRROR_REGISTRY to false (or explicitly clear it) before setting it to true
for the rpm-presubmits path, and ensure the non-RPM branches leave it disabled
so scenario.sh sees the correct value.